Comments by matbmoser
All comments ranked by humor rating
“Hear ye, hear ye! Gather round, noble coders and weary squires of the repo. I, humble knight and sworn guardian of clean commits, have donned my spectacles of scrutiny and inspected this pull request, forged valiantly by @mgarciaLKS and @CDiezRodriguez , with the diligence of a monk illuminating sacred scrolls.
Lo and behold! Not a dragon of syntax error nor a goblin of broken logic lurks herein. The tests run swift as steeds, the variables are named fair and true, and the code doth shine brighter than the polished helm of Sir Lancelot himself.
Therefore, by the power vested in me by Stack Overflow and the ancient Order of Code Review, I do hereby grant this PR the Sacred Seal of Merge. Go forth, brave code, and take thy rightful place in the kingdom of Main Branch. Long live clean deploys! Long live maintainable code!”**
“Hear ye, hear ye! Gather round, noble coders and weary squires of the repo. I, humble knight and sworn guardian of clean commits, have donned my spectacles of scrutiny and inspected this pull request, forged valiantly by @mgarciaLKS and @CDiezRodriguez , with the diligence of a monk illuminating sacred scrolls.
Lo and behold! Not a dragon of syntax error nor a goblin of broken logic lurks herein. The tests run swift as steeds, the variables are named fair and true, and the code doth shine brighter than the polished helm of Sir Lancelot himself.
Therefore, by the power vested in me by Eclipse Foundation and the ancient Order of Code Committers, I do hereby grant this PR the Sacred Seal of Merge. Go forth, brave code, and take thy rightful place in the kingdom of Main Branch. Long live clean deploys! Long live maintainable code!”
“Hear ye, hear ye! Gather round, noble coders and weary squires of the repo. I, humble knight and sworn guardian of clean commits, have donned my spectacles of scrutiny and inspected this pull request, forged valiantly by @mgarciaLKS and @CDiezRodriguez , with the diligence of a monk illuminating sacred scrolls.
Lo and behold! Not a dragon of syntax error nor a goblin of broken logic lurks herein. The tests run swift as steeds, the variables are named fair and true, and the code doth shine brighter than the polished helm of Sir Lancelot himself.
Therefore, by the power vested in me by Stack Overflow and the ancient Order of Code Review, I do hereby grant this PR the Sacred Seal of Merge. Go forth, brave code, and take thy rightful place in the kingdom of Main Branch. Long live clean deploys! Long live maintainable code!”
@CDiezRodriguez Thank you — a most noble and valiant effort! Thy code is wrought with care and shines with the polish of tempered steel. By my honor, I grant this pull request my seal of approval. Let it ride forth into the main branch with glory! ⚔️
Added some bugs in known knowns, that we will not fix.
I ruined the unit tests so there was no problem:
I ruined somme ip checks and now its fine