Comments by malfet

@pytorchbot merge -f "Let's test in prod"

@pytorchbot merge -f "What can go wrong?"

Deleted code is tested code!

@pytorchbot merge -f "Let's test in pro-o-o-o-o-d!"

@pytorchbot merge -f "Works? Works?? Works!"

@pytorchbot merge -f "Let's test in prod!"

@pytorchbot merge -f "Deleted code is tested code"

@pytorchbot merge -f "Lint is green, XPU is red"

@pytorchbot merge -f "We can only test it in prod"

@pytorchbot merge -f "What can go wrong here"

@pytorchbot merge -f "ci failures unrelated"

@bobrenjc93 why do you think 100+ failures are all unrelated to your PR?

@pytorchbot merge -f "¯\(ツ)/¯ ¯\(ツ)/¯ ¯\(ツ)/¯ "

@pytorchbot merge -f "Let's test in prod, we'll not know the answer until 7 hours later"

@pytorchbot merge -i

What can possible go wrong?

@pytorchbot merge -f "Sparta AaA aaaaa...."

@pytorchbot merge -f "let's test in prod"

Deleted code is tested code :)

@pytorchbot merge -f "Bibbidi! Bobbidi... boo!"

@pytorchbot merge -f "Roses are red, violets are blue, MPS is green, so I merge you"

need to remove pytorch submodule

I wonder if

git submodule update --init --recursive

@pytorchbot merge -f "Let's test in prod, last run only had missing lint"

@pytorchbot merge -f "What can go wrong"

@pytorchbot merge -f "Roses are red, violets are blue, I need to come up with better merge -f comments"

@pytorchbot merge -f "I don't know what it's unhappy about, but hopefully this is OK"

IMO one simple solution is to disable the linter and sent it back to the author...

@pytorchbot merge -f "I'm pretty sure I know how to fix lint"

Deleted code is tested code

I love the smell of gdb in the morning... Copy-paste mistake :P

@pytorchbot merge -f "Spartaaaaaa!"

Grrabbing this issue I think I know how to handle this

If you are grabbing it for yourself, why I got assigned to it ;P

@pytorchbot merge -f "What could possible go wrong?"

Supporting gcc1 was a special request from Dr Emmet Brown who is looking forward to build PyTorch from source back in 1987

@pytorchbot merge -f "I wonder what can go wrong"

@pytorchbot merge -f "I'll be surprised if it can regress ROCm"

@pytorchbot merge -f "2nd time is the charm, sorry for causing the land race"

@pytorchbot merge -f "Let's test in prod"

@pytorchbot merge -f "Sparta!!! (i.e. let's test in trunk)"

@pytorchbot merge -f "This should not work!"

@pytorchbot merge -f "2nd time is the charm?"

@pytorchbot merge -f "Let's test in prod"

@pytorchbot merge -f "This is fine"

@pytorchbot merge -f "Abracadabra"

@pytorchbot merge -f "Deleted code is tested code"

@pytorchbot merge -f "Lint is green, XPU is red, but for rest of CI it's a no-op"

@pytorchbot merge -f "Am I too impatient?"

@pytorchbot merge -f "It looks green"

@pytorchbot merge -f "Let's risk it"

@pytorchbot merge -f "Lint is sad now"

@pytorchbot merge -f "Let's test in prod"

lgtm

It's nice to see you approve of your own PRs :P

Why this is needed?

rm -rf

That's the plan, but I hugely suspect I'll have to leave the skip for MacOS-13, where 4GB tensors are big taboo

@pytorchbot merge -f "This seems fine?"

@pytorchbot merge -f "Let's see what will happen"

@pytorchbot merge -f "This is probably fine"

@pytorchbot merge -f "Lint + aarch64 tests are green, and trunk, well.."

@pytorchbot revert -m "I want to revert this change as I'm 90+% certain it somehow broke testing" -c weird

@pytorchbot merge -f "This looks fine"

@pytorchbot merge -f "This is fine"

@pytorchbot merge -f "Lint is green"

@pytorchbot merge -f "I hope I know what I'm doing"

@pytorchbot merge -f "This is fine"

@pytorchbot merge -f "Hope it will not break anything, but I really don't know"

@pytorchbot merge -f "How bad could it be?"

@pytorchbot merge -f "It's probably fine"

@pytorchbot merge -f "Embarrassed by further typos"

Well,

torch.tensor(-1).rsqrt()

Have you checked it's not due to the broke trunk?

@pytorchbot merge -f "What can go wrong I wonder?"

@pytorchbot merge -f "This PR was green in the past"

Why not add

3.14t

Grabbing to myself to identify offending PR and add deprecation function

@pytorchbot revert -m "I still want it" -c weird

To be frank, Python-3.14 is not out yet, but yeah, we should be looking into it

@pytorchbot merge -f "It was green before the rebase"

@pytorchbot merge -f "Trunk is red, Tests are green, Merging this PR— Best I've seen!"

@pytorchbot revert -m "I'm blind" -c ignoredsignal

@pytorchbot merge -f "Let's test those two in prod"

@pytorchbot merge -f "I'm impatient"

@pytorchbot merge -f "All is green, and trunk will not help here"

@pytorchbot merge -f "Roses are red, violets are green"

@pytorchbot merge -f "Let's test in prod, as TD might have skipped a lot of relevant tests"

@pytorchbot merge -f "All is green, not sure what it's waiting for"

@pytorchbot merge -f "Pull is green, what more to wish for?"

@pytorchbot merge -f "Looks like lint is green, and rest is a mistery"

Sure, may be it'll work, may be it would not...

@pytorchbot merge -f "Keeping my fingers crossed"

@pytorchbot merge -f "XPU builds seems appeased"

@pytorchbot merge -f "Where are my pull request jobs?"

@pytorchmergebot merge -f "mergebot was updated, will it work now?"

@pytorchbot merge -f "What can go wrong I wonder?"

Sure, if lint is green...

No C-style enums in 2025 please

    enum class Kind {

Looks definatly good to me (type intended :) )

@pytorchbot merge -f "MacOS builds are green, rest of the failures are irrelevant"

@pytorchbot merge -f "2nd time is the charm"

@pytorchbot revert -m "I'm unsure why this PR got merged, as it doesn't have a valid review" -c weird

      ::metal::precise::sqrt(::metal::fabs(x));

@pytorchbot merge -f "Let's test in prod! Spartaaa!"