Comments by fasterthanlime
All comments ranked by humor rating
This failed because of coverage, is it important to add tests for
stuff?Display
Nope, I merged it :)
Mhhh maybe the new branch protections are too strong x)
ALMOST there!
"single failure away from complete success" -- internal slack.
Oh this ain't my first CI rodeo I'm afraid x) cargo-llvm-cov it is, then.
ah we solved recursive types and broke generic types 💀
me looks at https://github.com/rust-lang/rfcs/pull/3490 and cries
Thanks! I'm merging this quickly so I have to deal with the merge conflicts later myself!
Nothing in this A"I" "review" discusses the actual trick,
That's true, but it did mention all the unrelated changes I snuck in, so 🤷
Oops, we don't love merge commits?
The royal we doesn't. I'm looking at how to recover but if we can't, then we can't
Nope just the default
One of us lying, I'll find out who & clean up the whitespace before merging (reader: we're friends, this is just good fun, I'm not being rude to a stranger)
I tried it first! But there's no "skip already published" option that I could find :(
--keep-goingThis helper is the morally correct thing to do, thanks for your service
PR number "french revolution" is on the way to save the day: #1789
(although CI is angery this afternoon)
https://github.com/facet-rs/facet/pull/1023 is merged, merry simdmas!
Is it supposed to be safe to implement
Facet
No,
FacetunsafeI have a PR ready for the std equivalents,
Ha, I also added it to this PR x)
I'm just going to roll back that conflict resolution merge and force re-push
No worries, I've got a clean rebase I'm merging now :)
- No C dependencies (pure Rust)
that's a lie btw — trading onig for tree-sitter
Some fresh test failures for you 🫡
Let me know if you need help or if you've got it!
No worries! I played whack-a-mole for 5 minutes, it was fun :P
Not sure how frequent you want these types of commits.
Once per week is probably good enough — we could set up dependabot :)
ohey you even read the CONTRIBUTING.md — hi james!