Comments by christophebedard

Approving since this works on my machine :tm:

CI is complaining that this repo doesn't have a

kilted

The rule is probably more like "no more than 1 sentence per line" while this is "maybe less than 1 sentence per line" :laughing:

I pushed an empty commit at first just to see what's broken. The answer is "basically all jobs."

so long, and thanks for all the fish turtles :turtle:

I hope to work on it over the next few months!

Famous last words.

Windows test failure is definitely unrelated.

@esteve do you want to create a PR to revert this revert PR/re-apply the original PR?

My bad, the search only shows RHEL 9 results by default :facepalm:

I'll just save Emerson some time and just merge it, since it definitely works :tm:

The issue is even if I clean everything and try to re-run the code it complains about the same.

You deleted

/home/max/my_bag

If you keep refreshing this page, it changes between "Regression" and "Passed" :exploding_head: https://build.ros2.org/job/Rpr__rosbag2__ubuntu_noble_amd64/631/testReport/junit/rosbag2_transport/RecordIntegrationTestFixture/published_messages_from_multiple_topics_are_recorded/

Thanks for the PR (again) and for making the fix!

Now I'll trigger CI and triple-check :laughing:

It doesn't really make sense, but I think the guideline is "licenses listed in a

package.xml

Maybe this could be a good opportunity to use an interrobang‽

It was simply never ported. PRs are welcome :smile: